feat(ml-api): redact secrets/PII from logs and route errors through it - #1016
Open
pavsoss wants to merge 2 commits into
Open
feat(ml-api): redact secrets/PII from logs and route errors through it#1016pavsoss wants to merge 2 commits into
pavsoss wants to merge 2 commits into
Conversation
|
@pavsoss is attempting to deploy a commit to the Aditya Sharma's projects Team on Vercel. A member of the Team first needs to authorize it. |
Userunknown84
requested changes
Jul 29, 2026
Userunknown84
left a comment
Userunknown84
left a comment
Owner
There was a problem hiding this comment.
Merge Conflict Shown kindly fix this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Builds on the JSON logging layer to make it safe and complete.
ErrorCodeand request id.Test plan
Regression coverage asserts each record is valid JSON, the request id propagates from the header, and known secrets/tokens/emails never appear in the output.
Dependency
Builds on #1006 part 1/2 (
feat/1006-logging-infra); merge after it. Until then this PR's diff includes part 1's commit.Part 2/2, Closes #1006.