fix(bulk-predict): mount router so the csv template endpoint is reachable - #1013
Merged
Userunknown84 merged 1 commit intoJul 29, 2026
Conversation
|
Someone is attempting to deploy a commit to the Aditya Sharma's projects Team on Vercel. A member of the Team first needs to authorize it. |
Userunknown84
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1002
Problem
backend/routes/bulkPredict.jsalready correctly definesGET /bulk-predict/template(and its ownPOST /bulk-predict), but the routerwas never required or mounted in
server.js, so the template download404'd.
Fix
A small, surgical 5-line change: require and mount
bulkPredict.jsat root,placed after
predictionRoutes(which already handles the real, activePOST /bulk-predictimplementation). This ordering meansbulkPredict.js's ownPOST /bulk-predicthandler stays shadowed —intentionally, so this fix doesn't regress the working upload flow — while
its
GET /bulk-predict/template, a pathpredictionRoutes.jsdoesn'tdefine, becomes reachable.
Left the now-shadowed duplicate
POST /bulk-predicthandler inbulkPredict.jsas-is with a comment explaining why; removing it is aseparate cleanup out of scope here.
Verification
node --checkandeslintclean (identical to unmodifiedupstream/mainon both touched files — no new issues). Functional check via
curlagainsta merged tree combined with
fix/backend-boot-crash(needed sincebulkPredictController.jstransitively requires a service file that didn'texist until that PR):
GET /bulk-predict/template→ 200, real CSV body;the existing
POST /bulk-predictflow unaffected.