-
Notifications
You must be signed in to change notification settings - Fork 9
feat: user office automatic joining of invitees to the #1260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yoganandaness
wants to merge
6
commits into
develop
Choose a base branch
from
SWAP-4914-user-office-automatic-joining-of-invitees-to-the
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
41d51cb
WIP
yoganandaness c364736
wip
yoganandaness c28ed92
feat: coproposer invite accept without code
yoganandaness cdc2577
fixed comments
yoganandaness a7c0356
Merge branch 'develop' into SWAP-4914-user-office-automatic-joining-o…
janosbabik fa831cb
Merge branch 'develop' into SWAP-4914-user-office-automatic-joining-o…
janosbabik File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
50 changes: 50 additions & 0 deletions
50
apps/backend/db_patches/db_seeds/0007_CoProposersInvite.sql
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| DO | ||
| $DO$ | ||
| DECLARE | ||
| invite_id_var1 int; | ||
| invite_id_var2 int; | ||
| invite_id_var3 int; | ||
| invite_id_var4 int; | ||
| BEGIN | ||
|
|
||
| INSERT INTO invites (code, email, created_by, created_at, claimed_by, claimed_at, is_email_sent, expires_at, template_id) | ||
| VALUES ('DAVE001', '[email protected]', 1, NOW(), NULL, NULL, false, NULL, 'user-office-registration-invitation-co-proposer'); | ||
|
|
||
| SELECT invite_id | ||
| INTO invite_id_var1 | ||
| FROM invites | ||
| WHERE email = '[email protected]' AND code = 'DAVE001'; | ||
|
|
||
| INSERT INTO invites (code, email, created_by, created_at, claimed_by, claimed_at, is_email_sent, expires_at, template_id) | ||
| VALUES ('BEN001', '[email protected]', 1, NOW(), NULL, NULL, false, NULL, 'user-office-registration-invitation-co-proposer'); | ||
|
|
||
| SELECT invite_id | ||
| INTO invite_id_var2 | ||
| FROM invites | ||
| WHERE email = '[email protected]' AND code = 'BEN001'; | ||
|
|
||
| INSERT INTO co_proposer_claims (invite_id, proposal_pk) VALUES (invite_id_var1, 1); | ||
| INSERT INTO co_proposer_claims (invite_id, proposal_pk) VALUES (invite_id_var2, 1); | ||
|
|
||
| INSERT INTO invites (code, email, created_by, created_at, claimed_by, claimed_at, is_email_sent, expires_at, template_id) | ||
| VALUES ('DAVE002', '[email protected]', 1, NOW(), NULL, NULL, false, NULL, ''); | ||
|
|
||
| SELECT invite_id | ||
| INTO invite_id_var3 | ||
| FROM invites | ||
| WHERE email = '[email protected]' AND code = 'DAVE002'; | ||
|
|
||
| INSERT INTO invites (code, email, created_by, created_at, claimed_by, claimed_at, is_email_sent, expires_at, template_id) | ||
| VALUES ('BEN002', '[email protected]', 1, NOW(), NULL, NULL, false, NULL, ''); | ||
|
|
||
| SELECT invite_id | ||
| INTO invite_id_var4 | ||
| FROM invites | ||
| WHERE email = '[email protected]' AND code = 'BEN002'; | ||
|
|
||
| INSERT INTO co_proposer_claims (invite_id, proposal_pk) VALUES (invite_id_var3, 2); | ||
| INSERT INTO co_proposer_claims (invite_id, proposal_pk) VALUES (invite_id_var4, 2); | ||
|
|
||
| END; | ||
| $DO$ | ||
| LANGUAGE plpgsql; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder why we actually need this table. Is it possible to create a single invitation for multiple proposals? If not, proposal_pk could be part of invites table.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not yet likely that an invite could be used for more than one proposal. However, the whole design is it make sure that the invite system works not just for entity like Proposal, but also for other entities like Reviewers, Instrument Scientist, Visits etc.,