BREAKING CHANGE: remove gender, telephone, username, position, placeholder, birthdate … #1126
Conversation
…and department columns from users table
bolmsten
changed the title
| $$ | ||
| BEGIN | ||
| IF register_patch( | ||
| '0182_RemoveUserColumns2.sql', |
There was a problem hiding this comment.
suggestion: No need for the numbers, they might go easily out of sync with the file name
| '0182_RemoveUserColumns2.sql', | |
| 'RemoveUserColumns2.sql', |
| // Check if email exist in database and if user has been invited before | ||
| const user = await this.dataSource.getByEmail(args.email); | ||
| if (user && user.placeholder) { | ||
| if (user) { |
There was a problem hiding this comment.
issue: I think this is fine, only now theelse if (user)clause is will never be called, we should probably clean it up
There was a problem hiding this comment.
This is where I am awaiting STFC to see if I can delete the whole function
|
How about removing preferred name as well? |
…re into SWAP-4778-View_Only_Profile
Co-authored-by: Jekabs Karklins <[email protected]>
I will raise it again with our user officer, the last time she identified this as a field she wants. Can STFC comment here on this? |
|
|
1 similar comment
|
|
github-actions
bot
force-pushed
the
SWAP-4778-View_Only_Profile
branch
2 times, most recently
from
4055aff to
18f2f45
Compare
…and department columns from users table
Co-authored-by: Jekabs Karklins <[email protected]>
github-actions
bot
force-pushed
the
SWAP-4778-View_Only_Profile
branch
from
18f2f45 to
bcac694
Compare
|
|
…oject/user-office-core into SWAP-4778-View_Only_Profile
|
|
…re into SWAP-4778-View_Only_Profile
| institutionRoRId: $institutionRoRId | ||
| institutionName: $institutionName | ||
| institutionCountry: $institutionCountry | ||
| department: $department |
There was a problem hiding this comment.
Department can be removed as well @yoganandaness
|
|
TCMeldrum
left a comment
TCMeldrum
left a comment
There was a problem hiding this comment.
Mentioned on teams but stfc would like to keep the legacy invite feature for the time being UserOfficeProject/issue-tracker#1479
|
|
Description
This PR removes redundant user attributes such as gender, telephone, username, position, placeholder, and birthdate in the backend and frontend of the application.
Motivation and Context
The removal of these attributes simplifies the user model and reduces the amount of unnecessary data stored in the database. This change is necessary as these attributes do not contribute to the core functionality of the application.
Changes
How Has This Been Tested?
Fixes Jira Issue
https://jira.esss.lu.se/browse/SWAP-4778
Depends On
Tests included/Docs Updated?