Add GithubOAuthPrivate registry backend AuthMode #231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new AuthMode for the registry backend, GithubOAuthPrivate. It is based on the GithubOAuth mode except that it requires any read or write access API callers to have at least view access on the index repository. This allows private registries to maintain full isolation without having to resort to API keys. It also enforces GitHub based ownership of scopes as GithubOAuth did.
This addition is not a breaking change: the GitHub access token provided to the backend does not need updated in order to check for index repository view access. The minimum required capabilities (content, metadata) of a fine-grained PAT allow checking the repository contributor permissions API.