Add Homepage and Repository fields to manifests #211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dekkonot
added
rust
magnalite
approved these changes
Nov 16, 2024
Contributor
magnalite
left a comment
magnalite
left a comment
There was a problem hiding this comment.
LGTM!
Tiny nitpick - The repo text can run off the edge of the webpage. (I don't think it is worth caring about right now unless the fix is trivial. Just eliding the link if it is too long is probably fine.)
Member
Author
|
So, looking into fixing this: the link gets truncated on desktop too, since it's too long for the column:
Even trimming off the scheme of the URL like crates.io doesn't work, as our text is too large. If we drop it down a few points though, it's perfectly fine with the scheme cut off: This does add a bit more work but it's probably worth it to ensure it looks okay? |
Deploying wally-registry-frontend with
|
| Latest commit: |
11e3a9a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://60ab0acb.wally-registry-frontend.pages.dev |
| Branch Preview URL: | https://test.wally-registry-frontend.pages.dev |
magnalite
approved these changes
Nov 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #180. Making a new PR because it's hard to repair that one after the work done on the site recently.
Closes #183.