Subcommand add and sub #160
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Very useful function that'll be used in the future.:
We're going to need this for add/remove
also fixed some compat problems.
That's where it belongs.
Lord... yay.
OverHash
reviewed
Jun 17, 2023
Now that VersionReq is bumped, we have the carot Carot is omitted by default if it's the only comparator.
Turbofish is kinda disgusting.
It used to ignore the last pair of keys since it wasn't inclusive. Meaning, e.g if there was 2 keys, it would start at 1. It would iterate while it was less than length - 1 = 1. 1 < 1 == false.
It would allow any versionreq despite it being invalid. Fixed.
.iter(), my darling.
Let's move as_table_name to utils, since it really shouldn't be publicly exposed. Maybe.
- Tests were fixed to support this. - PackageSpec.name() was added - add::PackageParam allows for aliases to specified.
- Added logging for whenever alias failed to match - If a dependency table becomes empty, it's deleted - Logging removal now specifies realm no matter what. - Changed AliasTarget to PackageParam - Ambigious alias now error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #74.