[pull] master from Roblox:master #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…that aren't included in selene's default config, we should make a new separate toml file that has only the new things we need, instead of editing and committing the roblox.toml
Co-authored-by: Paul Doyle <[email protected]>
* Add a CODE_OF_CONDUCT * Use selene and StyLua intstead of luacheck
Updates the version in preparation for a 0.4.0 release with the latest changes.
Small update before cutting 0.4.0; updating the package name to line up with newer conventions.
Add internal contributors to clabot
…m/Roblox/roact-rodux into LUAFDN-512-storeprovider-onechild
Use Roact.oneChild in StoreProvider
This is caused by some underlying reentrancy issues in the legacy Roact reconciliation process.
This should help de-duplicate rodux versions now that it moved to v3
* move rodux state alignment to didupdate * refactor to remove code duplication * Remove render child before parent test * Update changelog * use innerProps instead of props in the setState
…tions-manual Update GHA non-cached third party actions
…location in the Roblox org on GitHub (#65) This batch change updates the reference to the setup-foreman action to use the current location of the action in the Roblox org. This should be a no-op, or may fix currently-broken CI. Please refer to confluence for more information. Created by Sourcegraph batch change pdoyle/migrate-setup-foreman-action.
* Move traceback call * Bump tools * Stylua
This PR adds types for the dispatch prop and connect. This includes a standard action dispatch and a thunkful action dispatch variant. Note that I used the thunkful action dispatch as the default for connect(), which may or may not be desirable, but felt like a better default to me. Inspired by: https://github.com/reduxjs/react-redux/blob/master/src/types.ts This RP also adds typechecking to CI with luau-lsp.
EECI-4699: Update CLA Signature Bot
Make table form of mapDispatchToProps work with callable table actionCreators
We no longer use a CLA process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )