Closed
Conversation
|
This pull request was made to the wrong repository. If you are a participant, please close it and open it in your own fork instead. Refer to the Assignment Submission Guide for detailed instructions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Completed the missing Bash commands in 02_activities/assignments/assignment.sh using VS code.
(ie create and organize the data directory, move rawdata to data/raw, create processed subfolders for server, user, and event logs, copy the matching log files into the correct folders, remove files containing ipaddr, and generate data/inventory.txt.)
What did you learn from the changes you have made?
How to use basic Bash commands like mkdir, mv, cp, rm, ls, and find inside a script. Learned how to test a script from the mac Terminal, check whether the expected folders and files were created, and use Git commands like git add, git commit, and git push from the correct repository folder.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
Writing the folder creation and file-copying steps as multiple separate commands vs grouping some of them into shorter commands, like using mkdir -p to create nested folders in one line.
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
I got a little lost with understanding the difference between the Git repository folder and the newproject folder created by the script. At first, I tried to run Git commands from inside newproject, which caused path errors. I fixed this by going back to the main shell repository cd .. pwd ls and using the correct relative path: 02_activities/assignments/assignment.sh.
How were these changes tested?
I tested the script by running:
bash 02_activities/assignments/assignment.sh
A reference to a related issue in your repository (if applicable)
Checklist