UofT-DSI | <Production> - Assignment 2#167
Closed
1SeanBrennan1 wants to merge 2 commits intoUofT-DSI:mainfrom
Closed
UofT-DSI | <Production> - Assignment 2#1671SeanBrennan1 wants to merge 2 commits intoUofT-DSI:mainfrom
1SeanBrennan1 wants to merge 2 commits intoUofT-DSI:mainfrom
Conversation
|
Hello, thank you for your contribution. If you are a participant, please close this pull request and open it in your own forked repository instead of here. Please read the instructions on your onboarding Assignment Submission Guide more carefully. If you are not a participant, please give us up to 72 hours to review your PR. Alternatively, you can reach out to us directly to expedite the review process. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
I tried changing the model, but the simpler model still one.
What did you learn from the changes you have made?
lots more iterations needed to figure out teh best model...but sometimes teh simplest is the best.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
I would remove features to see if they are needed or not.
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
It was hard...but rewatched the classes, reread some of the book.
How were these changes tested?
A reference to a related issue in your repository (if applicable)
Checklist