Closed
Conversation
|
Hello, thank you for your contribution. If you are a participant, please close this pull request and open it in your own forked repository instead of here. Please read the instructions on your onboarding Assignment Submission Guide more carefully. If you are not a participant, please give us up to 72 hours to review your PR. Alternatively, you can reach out to us directly to expedite the review process. |
Author
|
Closing PR due to created by mistake. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Completed assignment 1.
What did you learn from the changes you have made?
Find files using glob, and loading parquet files in batch. Working with dask dataframe.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
No. Followed recommended approach for the assignment.
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
No issues.
How were these changes tested?
Checked number of parquet files found and loaded. Checked the output using head() to ensure lagging and returns are calculated properly. Pandas rolling average are calculated on sorted data within each group of tickers.
A reference to a related issue in your repository (if applicable)
N/A.
Checklist