Skip to content

Conversation

august-knox
Copy link

Adding caliper cmake option.
Caliper allows for performance analysis through source code annotations.
More info on caliper can be found here: https://software.llnl.gov/Caliper/

Copy link

@pearce8 pearce8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tomdeakin @giordano August is a student working with the benchpark group, and has instrumented your code with Caliper for measurements. Please consider his PR, everything is guarded by ifdef so will not impact your normal workflow.

@tomdeakin
Copy link
Contributor

This looks good, although I think this is for the driver code on main? There is a big refactor done in develop so not going to be a small job to port this over. I'll change the target and see what the merge conflicts look like...

@tomdeakin tomdeakin changed the base branch from main to develop February 8, 2025 11:44
@pearce8
Copy link

pearce8 commented Feb 8, 2025 via email

@august-knox
Copy link
Author

merge conflicts are now resolved. Should be good to merge!

@pearce8
Copy link

pearce8 commented Feb 28, 2025

This looks good, although I think this is for the driver code on main? There is a big refactor done in develop so not going to be a small job to port this over. I'll change the target and see what the merge conflicts look like...

@tomdeakin This PR now targets develop! Hopefully it is easier to merge.

@rfhaque rfhaque mentioned this pull request Jul 21, 2025
6 tasks
@pearce8
Copy link

pearce8 commented Sep 4, 2025

@tomdeakin Please merge this if it is ready from your perspective.

Copy link
Contributor

@tomdeakin tomdeakin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@tomdeakin tomdeakin merged commit 35e8ab7 into UoB-HPC:develop Sep 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants