perf(update): stop the app looking closed during update and restart - #5358
Merged
Merged
Conversation
Deleting a terminal agent-switch's leftover private artifacts is best-effort maintenance, not a safety invariant. A file left behind can be undeletable across restarts (e.g. a still-open handle or read-only attribute on Windows), so folding it into the boot-fatal error would refuse to bind the daemon forever. Record it as a maintenance fault and continue.
Reduce and mask update-restart latency without touching daemon safety fences: - Instant pre-React splash in index.html so there is no blank frame on boot. - Cross-platform post-update marker so the startup loader shows Updating/ Restarting copy instead of Connecting after an update relaunch. - Present the macOS update helper window on the normal swap path, not only on stall/failure. - Relocate agent-readiness warming to the post-ready callback so its ~24 subprocess probes no longer contend with the synchronous work that gates the port bind.
Address review of the update-restart visibility work: - The pre-React splash hardcoded the dark native background, flashing dark before the (default light) app theme resolved. Follow prefers-color-scheme so it matches the native window background in both themes. - consumeUpdateRelaunchFlag threw on a marker that parsed to a non-object (e.g. literal null); it now reads as "not an update" instead, honoring the never-block-startup contract. Drop the fromPID==pid guard so PID reuse after relaunch no longer produces a false negative; version + age + one-shot consume already gate correctness. - Time-bound the marker write before quitAndInstall so a hung filesystem write cannot stall the install. - Add regression tests for the marker contract.
The e2e tsconfig typecheck (renderer-smoke and test jobs) failed because the fake bridge did not implement the new updates.isPostUpdateRelaunch method. Add it to both update mocks.
The post-update relaunch check read aoBridge.updates.isPostUpdateRelaunch directly, which threw "Cannot read properties of undefined" in renderer tests and any preload/web fallback where the updates namespace is not present. Guard the access with optional chaining and a typeof check so a missing bridge simply means "not a post-update relaunch" and the loader still mounts.
quitAndInstallUpdate now writes the post-update relaunch marker (bounded) before calling quitAndInstall, so the non-darwin install defers past a microtask. The translocation-path test called it without awaiting and asserted quitAndInstall synchronously, which no longer holds. Await the call so the assertion runs after the marker write completes.
i-trytoohard
added
bug
illegalcall
self-requested a review
September 14, 2026 10:49
illegalcall
approved these changes
Sep 14, 2026
# Conflicts: # frontend/e2e/support/fake-bridge.ts
ronishrohan
pushed a commit
that referenced
this pull request
Sep 14, 2026
The static splash in index.html duplicates the existing React startup loader and briefly shows a hand-drawn SVG before the real app mounts. Restore the empty React root so startup follows the pre-#5358 behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splits the update-latency and boot-robustness work out of #5355. The sidebar restart-order fix that #5355 also carried is dropped in favor of #5348, which fixes that root cause more completely.
Problem
Updating the desktop app left it looking closed for up to a minute. There is no single 60s timeout: the gap is stacked waits, and the largest piece (the OS-level bundle/installer swap) is native to the updater and not reducible by us. The reducible parts are that the app showed nothing during that window and the new backend was slow to come back.
Changes
index.htmlremoves the blank frame before React mounts, on every OS and on both cold and post-update launch.update-relaunch-flag) lets the loader tell the user an update is in progress instead of a generic "connecting" (previously only macOS knew). New i18n strings across all locales.Verification
session_manageranddaemonsuites pass. New test covers the non-fatal cleanup.typecheckpasses.Out of scope
Keeping the daemon alive across the update (removes the backend re-boot but touches supervisor lifecycle and SQLite single-owner guarantees) and reducing the native OS installer swap (not reducible by us).