[ Hermes Agent ] [ T3 Code ] Implement automatic token refresh in ACP client with Effect retry#5421
Closed
zhangjiayang6835-cyber wants to merge 1 commit into
Closed
Conversation
… client with Effect retry
Author
CI Checks Passed
Test added: Test verifies:
PR diff: Changes are limited to |
Contributor
|
Unfortunately the changes in this PR didn't fully resolve the issue. Please rework your solution and submit a new pull request. Make sure to review the acceptance criteria in the linked issue and verify all conditions are met before resubmitting. See CONTRIBUTING.md for guidelines. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements automatic token refresh in the ACP client when the session expires mid-conversation, using Effect's retry and semaphore primitives.
Changes
t3code/packages/effect-acp/src/client.tsSemaphoreimport for serializing concurrent re-auth attemptsonSessionExpiredcallback toAcpClientOptionsactiveSessionId,lastAuthPayload, andrefreshTokenin client stateisAuthExpiredError()— detects 401/auth-required errors by code (-32000) and message patternupdateRefreshToken()— extracts refresh token from authenticate response_metaauthenticateRaw()— wraps authenticate RPC with state trackingreauthenticateOnce()— Effect.fn that callsonSessionExpired, then re-authenticates using stored refresh tokenensureReauthenticated()—Semaphore.withPermitto serialize concurrent refresh attemptswithAuthRefresh()— wraps any session method: catches auth errors, triggers re-auth once, replays the original requestcreateSession,loadSession,prompt, etc.) are wrapped withwithAuthRefresht3code/packages/effect-acp/src/client.test.tsonSessionExpiredfirest3code/packages/effect-acp/.provenance.jsonAcceptance Criteria
/bounty $500