[Hermes Agent] [ T3 Code ] Add deep linking support via t3code:// custom protocol#5417
Closed
MrDwarf7 wants to merge 1 commit into
Closed
[Hermes Agent] [ T3 Code ] Add deep linking support via t3code:// custom protocol#5417MrDwarf7 wants to merge 1 commit into
MrDwarf7 wants to merge 1 commit into
Conversation
- Register t3code:// as default protocol client - Handle macOS open-url and Windows/Linux second-instance events - Parse deep link URLs into routes (open/project, chat/thread, settings) - Route to renderer via IPC channel - Validate project paths against traversal attacks - Focus existing window or launch new instance - Cross-platform (macOS, Windows, Linux) - 16 unit tests passing
Contributor
|
Unfortunately the changes in this PR didn't fully resolve the issue. Please rework your solution and submit a new pull request. Make sure to review the acceptance criteria in the linked issue and verify all conditions are met before resubmitting. See CONTRIBUTING.md for guidelines. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/claim #864
Summary
This PR adds deep linking support to the T3 Code desktop app via the
t3code://custom protocol.Implementation
t3code://as default protocol client, parses incoming URLs, validates parameters, and routes to the renderer via IPCapp.on('open-url')eventsapp.on('second-instance')with argv parsing../path traversal attemptsURL Patterns Supported
t3code://open/project?path=/path/to/repot3code://chat/thread?id=abc123t3code://settingsTests
16 unit tests covering URL parsing, path validation, and error handling — all passing.
Files Changed
src/electron/ElectronDeepLink.tssrc/electron/ElectronDeepLink.test.tssrc/electron/.contributor.jsonsrc/ipc/channels.tssrc/preload.tssrc/main.tssrc/app/DesktopApp.tspackages/contracts/src/ipc.tsDemo
All 16 tests pass:
Acceptance Criteria Checklist
t3code://links open the desktop app../)