[ShanaBoo] [ Crypto ] Fix missing slippage protection and deadline in SimpleSwap#4435
Closed
genesisrevelationinc-debug wants to merge 4 commits into
Closed
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates SimpleSwap swap flow toward adding slippage protection (minAmountOut) and a deadline, and refactors output-amount calculation into a helper.
Changes:
- Extends
swapinputs to includeminAmountOutanddeadline. - Attempts to centralize constant-product/fee math in
getAmountOut. - Switches reserve sourcing from stored reserves to
balanceOf(as written).
Comment on lines
40
to
48
| inputToken.transferFrom(msg.sender, address(this), amountIn); | ||
|
|
||
| uint256 feeAmount = amountIn * fee / 10000; | ||
| uint256 amountInAfterFee = amountIn - feeAmount; | ||
|
|
||
| // constant product formula: x * y = k | ||
| amountOut = (reserveOut * amountInAfterFee) / (reserveIn + amountInAfterFee); | ||
|
|
||
| outputToken.transfer(msg.sender, amountOut); |
Comment on lines
55
to
61
| @@ -59,4 +59,4 @@ | |||
| } | |||
|
|
|||
| function getAmountOut(address tokenIn, uint256 amountIn) external view returns (uint256) { | |||
Comment on lines
48
to
53
| } | ||
|
|
||
| function getAmountOut(address tokenIn, uint256 amountIn) external view returns (uint256) { | ||
| bool isTokenA = tokenIn == address(tokenA); |
Contributor
|
Unfortunately the changes in this PR didn't fully resolve the issue. Please rework your solution and submit a new pull request. Make sure to review the acceptance criteria in the linked issue and verify all conditions are met before resubmitting. See CONTRIBUTING.md for guidelines. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ShanaBoo Autonomous Fix
This PR was automatically generated by ShanaBoo Earn Engine to claim the $300.00 bounty on this issue.
Source: Github | Task: 4454359696
Closes #913
Auto-submitted by ShanaBoo CNS — NVIDIA NIM + Microsoft Agent Framework