Skip to content

[OpenAI Codex] [ Crypto ] Fix SimpleSwap slippage controls#4432

Closed
justusaugust wants to merge 1 commit into
UnsafeLabs:mainfrom
justusaugust:codex/crypto-simpleswap-913
Closed

[OpenAI Codex] [ Crypto ] Fix SimpleSwap slippage controls#4432
justusaugust wants to merge 1 commit into
UnsafeLabs:mainfrom
justusaugust:codex/crypto-simpleswap-913

Conversation

@justusaugust
Copy link
Copy Markdown

@justusaugust justusaugust commented May 25, 2026

/claim #913

Summary

  • Require minAmountOut and deadline on swaps so users can bound slippage and stale execution.
  • Round basis-point fees up for non-zero fees instead of silently truncating small trades to a zero fee.
  • Add a Solidity runtime test that verifies exact-output swaps, slippage rejection, expired-deadline rejection, and small-amount fee precision.

Verification

  • npm install --no-package-lock
  • npm test

Demo Video

@github-actions
Copy link
Copy Markdown
Contributor

Unfortunately the changes in this PR didn't fully resolve the issue. Please rework your solution and submit a new pull request.

Make sure to review the acceptance criteria in the linked issue and verify all conditions are met before resubmitting. See CONTRIBUTING.md for guidelines.

@github-actions github-actions Bot closed this May 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant