Skip to content

Commit

Permalink
(MAJOR) Update node from v16 to v20 (#106)
Browse files Browse the repository at this point in the history
* Update node from v16 to v20

* Run tests on v20

* Use ubuntu-latest instead of fixed version
  • Loading branch information
Vadorequest authored Apr 11, 2024
1 parent 3d536f0 commit dc8556d
Show file tree
Hide file tree
Showing 8 changed files with 12 additions and 12 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/auto-git-release-production.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ on:

jobs:
tag-and-release:
runs-on: ubuntu-22.04
runs-on: ubuntu-latest
steps:
- name: Fetching all commits for the current branch
uses: actions/checkout@v3
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/auto-git-release-staging.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ on:

jobs:
tag-and-release:
runs-on: ubuntu-22.04
runs-on: ubuntu-latest
steps:
- name: Fetching all commits for the current branch
uses: actions/checkout@v3
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/check-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
strategy:
matrix:
version: [ 16, 18, 20 ]
runs-on: ubuntu-22.04
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/run-integration-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
strategy:
matrix:
version: [ 16, 18, 20 ]
runs-on: ubuntu-22.04
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- run: yarn # Install all dependencies
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/update-codeclimate-coverage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,16 +15,16 @@ jobs:
# Configures the deployment environment, install dependencies (like node, npm, etc.) that are requirements for the upcoming jobs
# Ex: Necessary to run `yarn test:coverage`
setup-environment:
name: Setup deployment environment (Ubuntu 22.04 - Node 18.x)
runs-on: ubuntu-22.04
name: Setup deployment environment (Ubuntu 22.04 - Node 20.x)
runs-on: ubuntu-latest
steps:
- name: Installing node.js
uses: actions/setup-node@v3 # Used to install node environment - XXX https://github.com/actions/setup-node
with:
node-version: 18 # Use the same node.js version as the one Vercel's uses (currently node18.x)
node-version: 20 # Use the same node.js version as the one Vercel's uses (currently node20.x)
run-tests-coverage:
name: Run tests coverage and send report to Code Climate
runs-on: ubuntu-22.04
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- name: Installing dependencies
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v18
v20
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
```yaml
jobs:
wait-for-vercel-deployment:
runs-on: ubuntu-22.04
runs-on: ubuntu-latest
steps:
- uses: UnlyEd/github-action-await-vercel@v1 # TODO best practices recommend to use a fixed version instead of @v1 for production usage (i.e: @v1.2.32)
id: await-vercel
Expand Down Expand Up @@ -116,7 +116,7 @@ on:
jobs:
wait-for-vercel-deployment:
runs-on: ubuntu-22.04
runs-on: ubuntu-latest
steps:
- name: Retrieve deployment URL (example on how to set an ENV var)
run: "echo VERCEL_DEPLOYMENT_URL=nextjs-bzyss249z.vercel.app >> $GITHUB_ENV"
Expand Down
2 changes: 1 addition & 1 deletion action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,5 @@ outputs:
deploymentDetails:
description: 'Forwarded Vercel API response - See https://vercel.com/docs/api#endpoints/deployments/get-a-single-deployment/response-parameters'
runs:
using: 'node16'
using: 'node20'
main: 'github-action-runtime/index.js'

0 comments on commit dc8556d

Please sign in to comment.