feat: respect etag from server #113
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tymek
reviewed
Oct 23, 2025
| if (fetchOptions.headers) { | ||
| Object.entries(fetchOptions.headers).forEach(([key, value]) => { | ||
| headers[key.toLowerCase()] = value; | ||
| if (value != null) { |
Contributor
There was a problem hiding this comment.
good change with null value. a test covering that could be useful
Tymek
approved these changes
Oct 23, 2025
Contributor
Tymek
left a comment
Tymek
left a comment
There was a problem hiding this comment.
Ok, in theory this should work. If we get 304 only after sending "if none match", that's good. It also opens doors to other types of caching, for example time-based, in the future.
Comment on lines
+47
to
+49
| mockFetch.mockResolvedValue( | ||
| createResponse({ version: 1, features: [] }, { etag: "etag-1" }) | ||
| ); |
Contributor
There was a problem hiding this comment.
I don't think there should be a need to change all previous tests
github-project-automation
bot
moved this from In Progress
to Approved PRs
in Issues and PRs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
This tries to respect etag from the server and send that as If-None-Match header when fetching.