refactor: extract UNINSTALLED_PACKAGES_FILE_NAME_FORMAT into a const #799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, I forgot, Rust has strict rules about macro parameters — in this case, it's for safety against incorrect argument types/count. What would work in other languages, will not in Rust (even though other languages also have similar protections via lint). We have two options, then, use a simple |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Rudxain
approved these changes
Jan 16, 2025
Rudxain
dismissed
AnonymousWP’s stale review
I've fixed the compilation error
Rudxain
deleted the
refactor/extract-uninstalled_packages_file_name_format-into-const
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #796. Needs testing, I can't because of this.