Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(ci): remove exclude and add MacOS-13 to CI #793

Merged
merged 1 commit into from
Jan 13, 2025
Merged

build(ci): remove exclude and add MacOS-13 to CI #793

merged 1 commit into from
Jan 13, 2025

Conversation

AnonymousWP
Copy link
Member

No description provided.

@AnonymousWP AnonymousWP added the ci Continuous Integration label Jan 13, 2025
@AnonymousWP AnonymousWP requested a review from a team January 13, 2025 11:22
@AnonymousWP AnonymousWP marked this pull request as draft January 13, 2025 11:29
@AnonymousWP AnonymousWP mentioned this pull request Jan 13, 2025
Closed
@AnonymousWP
Copy link
Member Author

Asked users to test this first: #722 (comment)

@AnonymousWP AnonymousWP force-pushed the fix-incorrect-ci-file branch from f7f9391 to f1bc2fe Compare January 13, 2025 14:11
Rudxain
Rudxain previously approved these changes Jan 13, 2025
View reviewed changes
@Rudxain Rudxain marked this pull request as ready for review January 13, 2025 19:00
@Rudxain
Copy link
Member

Rudxain commented Jan 13, 2025

Wait, don't merge. Why does this have commits about tiny_skia? Instead of reverting, I would recommend deleting the commits from the history, to avoid potential problems

@Rudxain Rudxain marked this pull request as draft January 13, 2025 19:05
@Rudxain
Copy link
Member

Rudxain commented Jan 13, 2025

Is this branch based on #794 or is it backwards?

@AnonymousWP
Copy link
Member Author

Wait, don't merge. Why does this have commits about tiny_skia? Instead of reverting, I would recommend deleting the commits from the history, to avoid potential problems

See https://discord.com/channels/1168607797081022514/1207249059346260008/1328378703398305814. I'll check how I can easily bring it back to 1 commit. I don't need to do that often, so I don't know from the top of my head.

Is this branch based on #794 or is it backwards?

Both are based on master, but #794 needs these changes, otherwise I get a workflow error. Was thinking of basing this PR on that branch, but wasn't sure as the other PR could still change too.

@AnonymousWP AnonymousWP force-pushed the fix-incorrect-ci-file branch 4 times, most recently from 5f48094 to 9cda368 Compare January 13, 2025 20:56
@AnonymousWP AnonymousWP force-pushed the fix-incorrect-ci-file branch from 9cda368 to 2d77c15 Compare January 13, 2025 20:58
@AnonymousWP
Copy link
Member Author

@Rudxain Sorry for the mess, should be good now. Can you confirm?

@AnonymousWP AnonymousWP marked this pull request as ready for review January 13, 2025 20:58
@AnonymousWP AnonymousWP requested a review from Rudxain January 13, 2025 20:58
Rudxain
Rudxain approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@Rudxain Rudxain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AnonymousWP AnonymousWP merged commit c9eeed3 into main Jan 13, 2025
@AnonymousWP AnonymousWP deleted the fix-incorrect-ci-file branch January 13, 2025 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rudxain Rudxain Rudxain approved these changes

Assignees
No one assigned
Labels
ci Continuous Integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AnonymousWP @Rudxain