-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(ci): fix macOS linting failing #730
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Since AWP is taking some time because of personal reasons (they explained it in a Discord channel), I'll commit the changes. I'm announcing this in advance, to prevent merge-conflicts |
This comment was marked as outdated.
This comment was marked as outdated.
That's the only palette field that's pure black. It's part of the So we have 3 (or more?) options:
|
Here's the code health analysis summary for commits Analysis Summary
|
I forgot to request review from @Frigyes06 😅 |
Looks like for MacOS we need to allow
bright.surface
to be black. This seems to have fixed it.Follow-up of #654