Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(ci): fix macOS linting failing #730

Merged
merged 9 commits into from
Dec 8, 2024
Merged

Conversation

AnonymousWP
Copy link
Member

@AnonymousWP AnonymousWP commented Nov 23, 2024

Looks like for MacOS we need to allow bright.surface to be black. This seems to have fixed it.

Follow-up of #654

@AnonymousWP AnonymousWP added the testing Validation and tests label Nov 23, 2024
@AnonymousWP AnonymousWP requested a review from a team November 23, 2024 19:14
@AnonymousWP AnonymousWP linked an issue Nov 23, 2024 that may be closed by this pull request
3 tasks
src/gui/style.rs Outdated Show resolved Hide resolved
src/gui/style.rs Outdated Show resolved Hide resolved
@Rudxain

This comment was marked as outdated.

@Rudxain
Copy link
Member

Rudxain commented Dec 8, 2024

Since AWP is taking some time because of personal reasons (they explained it in a Discord channel), I'll commit the changes. I'm announcing this in advance, to prevent merge-conflicts

@Rudxain

This comment was marked as outdated.

@Rudxain
Copy link
Member

Rudxain commented Dec 8, 2024

That's the only palette field that's pure black. It's part of the LIGHT color-scheme. According to this, this implies the macOS theme is Light by default (or cannot be detected).

So we have 3 (or more?) options:

  • Modify the LIGHT theme such that the field is no longer black
  • Don't rely on Theme::default() and use Theme::Dark explicitly
  • Delete/comment-out that one problematic assertion

Copy link
Contributor

deepsource-io bot commented Dec 8, 2024

Here's the code health analysis summary for commits 9295c8b..f151f54. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Rust LogoRust✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage⚠️ Artifact not reportedTimed out: Artifact was never reportedView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@Rudxain Rudxain merged commit b8f6688 into main Dec 8, 2024
20 of 21 checks passed
@Rudxain Rudxain deleted the 729-bugci-macos-lint-fails branch December 8, 2024 04:02
@Rudxain
Copy link
Member

Rudxain commented Dec 8, 2024

I forgot to request review from @Frigyes06 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Validation and tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(ci): MacOS lint fails
2 participants