Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg(com.heytap.pictorial): add note about wallpaper carousel #678

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

pkg(com.heytap.pictorial): add note about wallpaper carousel #678

wants to merge 6 commits into from

Conversation

AnonymousWP
Copy link
Member

No description provided.

@AnonymousWP AnonymousWP added the package::documentation Improve a description/recommendation label Oct 5, 2024
@AnonymousWP AnonymousWP linked an issue Oct 5, 2024 that may be closed by this pull request
pkg(scope): Addition about com.heytap.pictorial #618
Open
3 tasks
@deepsource-io deepsource.io
Copy link
Contributor

deepsource-io bot commented Oct 5, 2024 •
edited
Loading

Here's the code health analysis summary for commits b8f6688..70a9948. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Rust LogoRust✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage⚠️ Artifact not reportedTimed out: Artifact was never reportedView Check ↗
💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@AnonymousWP AnonymousWP requested a review from a team November 23, 2024 19:27
@schbrns schbrns assigned schbrns and unassigned schbrns Nov 25, 2024
@AnonymousWP
Copy link
Member Author

Now I think of it. Shouldn't the removal be Recommended? See https://github.com/Universal-Debloater-Alliance/universal-android-debloater-next-generation/wiki/FAQ.

@Rudxain
Copy link
Member

Rudxain commented Dec 26, 2024

I agree with Recommended

@schbrns
Copy link
Contributor

schbrns commented Dec 27, 2024

Agreed, I thought I suggested Recommended for this.
The issue wording was misleading, this app is working exactly as intended.
As per the updated label and description, it causes your wallpaper to change with every unlock.

@schbrns
Copy link
Contributor

schbrns commented Dec 27, 2024

Or maybe I wasn't sure how to expand the commit without creating a new one. 🧐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schbrns schbrns schbrns left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
package::documentation Improve a description/recommendation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pkg(scope): Addition about com.heytap.pictorial
3 participants
@AnonymousWP @Rudxain @schbrns