Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(sync): remove set_var in favor of adb_id #653

Closed
wants to merge 19 commits into from

Conversation

Rudxain
Copy link
Member

@Rudxain Rudxain commented Sep 24, 2024

Copy link
Contributor

deepsource-io bot commented Sep 24, 2024

Here's the code health analysis summary for commits b8f6688..04b3ef5. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Rust LogoRust❌ Failure
❗ 10 occurences introduced
🎯 15 occurences resolved
View Check ↗
DeepSource Test coverage LogoTest coverage⚠️ Artifact not reportedTimed out: Artifact was never reportedView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@Rudxain Rudxain added the refactor Rework of code — behaviour doesn't change label Sep 25, 2024
src/core/sync.rs Outdated Show resolved Hide resolved
src/gui/mod.rs Show resolved Hide resolved
@Rudxain Rudxain changed the title refactor: sync & set_var refactor(sync): remove set_var in favor of explicit device serial Dec 7, 2024
@Rudxain Rudxain changed the title refactor(sync): remove set_var in favor of explicit device serial refactor(sync): remove set_var in favor of adb_id Dec 7, 2024
@Rudxain Rudxain added the documentation Improvements or additions to documentation label Dec 7, 2024
@Rudxain Rudxain marked this pull request as ready for review December 7, 2024 14:27
@Rudxain Rudxain requested a review from a team December 7, 2024 14:28
@Rudxain Rudxain marked this pull request as draft December 8, 2024 07:29
@Rudxain Rudxain removed the request for review from a team December 8, 2024 07:29
@Rudxain Rudxain marked this pull request as ready for review December 8, 2024 09:56
@Rudxain Rudxain requested a review from a team December 8, 2024 09:57
@Rudxain Rudxain self-assigned this Dec 8, 2024
@Rudxain

This comment was marked as outdated.

@Rudxain Rudxain removed the request for review from a team December 14, 2024 13:11
@Rudxain
Copy link
Member Author

Rudxain commented Dec 14, 2024

Superseded by #757

@Rudxain Rudxain closed this Dec 14, 2024
@Rudxain Rudxain deleted the refactor/sync-and-set_var branch December 14, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation refactor Rework of code — behaviour doesn't change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants