-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(sync
): remove set_var
in favor of adb_id
#653
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here's the code health analysis summary for commits Analysis Summary
|
adhirajsinghchauhan
requested changes
Sep 25, 2024
Rudxain
commented
Nov 26, 2024
Rudxain
commented
Nov 26, 2024
Rudxain
commented
Nov 26, 2024
Rudxain
changed the title
refactor:
refactor(Dec 7, 2024
sync
& set_var
sync
): remove set_var
in favor of explicit device serial
Rudxain
changed the title
refactor(
refactor(Dec 7, 2024
sync
): remove set_var
in favor of explicit device serialsync
): remove set_var
in favor of adb_id
This comment was marked as outdated.
This comment was marked as outdated.
Superseded by #757 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
refactor
Rework of code — behaviour doesn't change
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since all calls toset_var
specifyANDROID_SERIAL
as key, I decided to define a function for itANDROID_SERIAL
, mostfn
s now have to explicitly specify the device serial ID. See why env-vars are unsafe and set_var/remove_var are unsound in combination with C code that reads the environment rust-lang/rust#27970supports_multi_user
helper, because of thislist_all_system_packages
APIconst
s, as explained here