rewrite ssh key logic

[simonLeary42]

before:

• duplicate and invalid keys are silently ignored
• when github API returns no keys, nothing happens and the user is left scratching their head
• private keys are accepted and written to world-readable LDAP
• lots of strange key types and key formats are accepted (ex: DSA, JWT)
• when writing multiple keys, there is only one LDAP write (fast)

after:

• added message when key is added
• added message when key is removed
• added message when duplicate key is skipped
• added message when key is invalid
• added message when github API returns empty array
• only configured [ldap][allowed_ssh_public_key_types] key types are accepted
• only authorized_keys-formatted keys are accepted
• private keys are not accepted
• when adding multiple keys, there is one LDAP write per key (slow)
  • this happens only when importing from github and even then it should only typically be a small number of keys

Screen.Recording.2025-12-18.at.12.40.14.PM.mov

TODO:

• decide what to do with currently unused UnityUser->sshKeyExists() function
• enforce phpseclib-compatible authorized_keys-style public key format with regex
• switch from load to loadPublicKey
• display key invalid message in modal for paste key

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 8 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 8 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.