user flag groups #396
Merged
user flag groups #396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonLeary42
force-pushed
the
user-modifiers
branch
2 times, most recently
from
1fb27b0 to
96931e9
Compare
simonLeary42
force-pushed
the
user-modifiers
branch
from
96931e9 to
d5de879
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 25 out of 25 changed files in this pull request and generated 17 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
simonLeary42
force-pushed
the
user-modifiers
branch
from
72cbebf to
e9a5779
Compare
simonLeary42
force-pushed
the
user-modifiers
branch
3 times, most recently
from
8bfae4c to
43d3d36
Compare
simonLeary42
force-pushed
the
user-modifiers
branch
from
43d3d36 to
97caee1
Compare
simonLeary42
force-pushed
the
user-modifiers
branch
from
10d0587 to
1000e4e
Compare
bryank-cs
previously approved these changes
Dec 18, 2025
Co-authored-by: bryank-cs <[email protected]>
Co-authored-by: bryank-cs <[email protected]>
Co-authored-by: bryank-cs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New posixGroups need to be managed as part of user lifecycle management. Rather than implementing
setIsAdminisLockedsetIsLockedisIdleLockedsetIsIdleLockedisGhostsetIsGhost, I generalized these groups into "user flags", and changedisQualified/setIsQualifiedintogetFlag/setFlag.In this PR I am only adding the groups, I am not adding any logic for working with the groups.
"activated" (qualified) email still seems normal: