curl throw exception (#363)

Author: simonLeary42

resources/autoload.php

@@ -28,6 +28,7 @@
 require_once __DIR__ . "/lib/exceptions/NoDieException.php";
 require_once __DIR__ . "/lib/exceptions/SSOException.php";
 require_once __DIR__ . "/lib/exceptions/ArrayKeyException.php";
+require_once __DIR__ . "/lib/exceptions/CurlException.php";
 require_once __DIR__ . "/lib/exceptions/EntryNotFoundException.php";
 require_once __DIR__ . "/lib/exceptions/EnsureException.php";
 require_once __DIR__ . "/lib/exceptions/EncodingUnknownException.php";

resources/lib/UnityGithub.php

@@ -1,6 +1,7 @@
 <?php
 
 namespace UnityWebPortal\lib;
+use UnityWebPortal\lib\exceptions\CurlException;
 
 class UnityGithub
 {
@@ -13,7 +14,11 @@ public function getSshPublicKeys(string $username): array
         curl_setopt($curl, CURLOPT_URL, $url);
         curl_setopt($curl, CURLOPT_RETURNTRANSFER, 1);
         curl_setopt($curl, CURLOPT_HTTPHEADER, $headers);
-        $keys = json_decode(curl_exec($curl), false);
+        $curl_output = curl_exec($curl);
+        if ($curl_output === false) {
+            throw new CurlException(curl_error($curl));
+        }
+        $keys = json_decode($curl_output, false);
         curl_close($curl);
 
         // normally returns array of objects each with a ->key attribute

resources/lib/exceptions/CurlException.php

@@ -0,0 +1,5 @@
+<?php
+
+namespace UnityWebPortal\lib\exceptions;
+
+class CurlException extends \Exception {}

test/phpunit-bootstrap.php

@@ -19,6 +19,7 @@
 require_once __DIR__ . "/../resources/lib/exceptions/NoDieException.php";
 require_once __DIR__ . "/../resources/lib/exceptions/SSOException.php";
 require_once __DIR__ . "/../resources/lib/exceptions/ArrayKeyException.php";
+require_once __DIR__ . "/../resources/lib/exceptions/CurlException.php";
 require_once __DIR__ . "/../resources/lib/exceptions/EntryNotFoundException.php";
 require_once __DIR__ . "/../resources/lib/exceptions/EnsureException.php";
 require_once __DIR__ . "/../resources/lib/exceptions/EncodingUnknownException.php";