remove redis flush from tests (#367)

Author: simonLeary42

test/functional/PIBecomeApproveTest.php

@@ -67,8 +67,6 @@ public function testApprovePI()
             $this->requestGroupCreation();
             $this->assertRequestedPIGroup(true);
 
-            $REDIS->flushAll(); // regression test: flush used to break requests
-
             $approve_uid = $SSO["user"];
             switchUser(...getAdminUser());
             $this->approveGroup($approve_uid);

test/functional/PiMemberApproveTest.php

@@ -114,8 +114,6 @@ public function testApproveMemberByPI()
             $this->assertTrue($pi_group->requestExists($USER));
             $this->assertRequestedMembership(true, $gid);
 
-            $REDIS->flushAll(); // regression test: flush used to break requests
-
             $approve_uid = $SSO["user"];
             switchUser(...$pi_user_args);
             $this->approveUserByPI($approve_uid);
@@ -176,8 +174,6 @@ public function testApproveMemberByAdmin()
             $this->assertTrue($pi_group->requestExists($USER));
             $this->assertRequestedMembership(true, $gid);
 
-            $REDIS->flushAll(); // regression test: flush used to break requests
-
             $approve_uid = $SSO["user"];
             switchUser(...getAdminUser());
             $this->approveUserByAdmin($gid, $approve_uid);