chore: remove the Vivox eval suite - #64
Open
ziyiunity wants to merge 1 commit into
Open
Conversation
The suite needs internal-only infrastructure to run, so it cannot be executed by anyone consuming this repo, and one of its files points at an internal endpoint. It stays available in this repo's history.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the seven-file promptfoo eval suite under
skills/setup-vivox-voice-chat/evals/.Why
The suite cannot be run by anyone consuming this repo. It is wired to an internal-only model gateway, so an external reader gets a set of files that will not execute for them, downloaded as part of the skill. One of those files also carries the internal endpoint's address, which does not belong in a public repo.
Nothing else in the repo references the directory, so this leaves no dangling links. The content stays available in this repo's history if we want to rehome it in an internal repo, which is where an eval suite that needs internal infrastructure belongs.
Scope
Deletion only. The
setup-vivox-voice-chatskill itself, itsSKILL.md, and its references are untouched.