Add Addressables Report support #29

timt-unity3d · 2025-07-08T18:13:40Z

No description provided.

Copilot

Pull Request Overview

This PR adds support for importing Unity Addressables build reports by parsing JSON build layout files and writing their data into new SQLite tables.

Introduce WriteAddressablesBuild in SQLiteWriter and register all related commands.
Add dozens of AbstractCommand subclasses to support addressables tables.
Update database schema (Init.sql) and analyzer tool to handle .json Addressables build reports.

Reviewed Changes

Copilot reviewed 32 out of 33 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
Analyzer/SQLite/SQLiteWriter.cs	Register and use new Addressables build commands; implement `WriteAddressablesBuild`.
Analyzer/SQLite/Commands/*.cs	Add command classes for each addressables-related table.
Analyzer/Resources/Init.sql	Create all `addr_build_*` tables for addressables data.
Analyzer/AnalyzerTool.cs	Detect `.json` files and route to `ProcessAddressablesBuild`.
Analyzer/Analyzer.csproj	Add `Newtonsoft.Json` package for JSON deserialization.

Comments suppressed due to low confidence (2)

Analyzer/SQLite/SQLiteWriter.cs:62

[nitpick] The field name 'm_AddressablesDataFromOtherAsset' is missing 'Build' after 'Addressables'. Consider renaming to 'm_AddressablesBuildDataFromOtherAsset' for consistency.

    private AddressablesBuildDataFromOtherAsset m_AddressablesDataFromOtherAsset = new AddressablesBuildDataFromOtherAsset();

Analyzer/SQLite/SQLiteWriter.cs:259

This new method contains substantial logic for parsing and inserting data; consider adding unit tests to cover key code paths and error handling.

    public void WriteAddressablesBuild(string filename, BuildLayout buildLayout)

Copilot · 2025-07-08T18:15:38Z

Analyzer/SQLite/Commands/AddressablesBuild.cs

+        {
+            { "name", SqliteType.Text },
+            { "build_target", SqliteType.Integer },
+            { "start_time", SqliteType.Integer },


The field mapping for 'start_time' is defined as SqliteType.Integer, but the table schema declares it as TEXT. Consider changing it to SqliteType.Text to match the schema and avoid type mismatches.

Suggested change

{ "start_time", SqliteType.Integer },

{ "start_time", SqliteType.Text },

Copilot · 2025-07-08T18:15:38Z

Analyzer/SQLite/SQLiteWriter.cs

@@ -6,28 +6,33 @@
 using UnityDataTools.Analyzer.SQLite.Handlers;
 using UnityDataTools.FileSystem;
 using UnityDataTools.FileSystem.TypeTreeReaders;
+using UnityDataTools.Analyzer.Build;
+using static System.Runtime.InteropServices.JavaScript.JSType;
+using System.Xml.Linq;


The 'System.Xml.Linq' namespace is not used in this file; you can remove this import to reduce clutter.

Suggested change

using System.Xml.Linq;

Copilot · 2025-07-08T18:15:39Z

Analyzer/SQLite/SQLiteWriter.cs

@@ -6,28 +6,33 @@
 using UnityDataTools.Analyzer.SQLite.Handlers;
 using UnityDataTools.FileSystem;
 using UnityDataTools.FileSystem.TypeTreeReaders;
+using UnityDataTools.Analyzer.Build;
+using static System.Runtime.InteropServices.JavaScript.JSType;


The static import of 'JSType' is not used; removing it will improve clarity.

Suggested change

using static System.Runtime.InteropServices.JavaScript.JSType;

Copilot · 2025-07-08T18:15:39Z

Analyzer/SQLite/SQLiteWriter.cs

+        m_AddressablesBuildBundleFile.CreateCommand(m_Database);
+
+        // Data From Other Asset Tables
+        // Data From Other Asset Tables


[nitpick] This comment is duplicated on the previous line. Removing one occurrence will keep the code cleaner.

Suggested change

// Data From Other Asset Tables

SkowronskiAndrew · 2025-07-09T20:08:35Z

Analyzer/AnalyzerTool.cs

+            EraseProgressLine();
+            Console.Error.WriteLine();
+            Console.Error.WriteLine($"Error processing file: {file}");
+            Console.WriteLine($"{e.GetType()}: {e.Message}");


.json is a standard file, and there will be .json files in a player output.

For those we should ideally continue to be silent or a minor warning about ignoring it.

Maybe there is a way to first just sanity check that it really is a Addressables build report, perhaps by peeking at the start of the file to check for clear expected formatting?

Or attempting to parsing it but only logging the full error if further analysis proves it is a Addressable file?

SkowronskiAndrew · 2025-07-09T20:17:34Z

Analyzer/Resources/Init.sql

+    PRIMARY KEY (id)
+);
+
+create table addr_build_bundles


I'm not sure the short form will be immediately apparent to everyone "addr_build" as short for for Addressables Build.

Suggested change

create table addr_build_bundles

create table addressables_bundles

I wonder if there is any easy way to make all these tables optional, e.g. only created if we actually find Addressables file? I"m thinking now the dropdown of Tables will start with quite a long list of tables that will be all empty for some builds. Not the end of the world but if they are self contained maybe this can be a sql file that is only run when we discover the file?

SkowronskiAndrew

I took an initial peek at the code (but didn't try it out)
So far just a few suggestions about organizing the new functionality with a bit more structure, which probably could pay off as establishing a pattern for other build-pipeline-specific tables we might add in future.

SkowronskiAndrew · 2025-07-09T20:18:45Z

Analyzer/SQLite/Commands/AddressablesBuild.cs

+{
+    internal class AddressablesBuild : AbstractCommand
+    {
+        protected override string TableName { get => "addr_builds"; }


Suggested change

protected override string TableName { get => "addr_builds"; }

protected override string TableName { get => "addressables_builds"; }

SkowronskiAndrew · 2025-07-09T20:23:58Z

Analyzer/SQLite/SQLiteWriter.cs

+        m_AddressablesBuildSubFile.SetValue("size", reference.data.Size);
+        m_AddressablesBuildSubFile.ExecuteNonQuery();
+    }
+


The SQLiteWriter.cs starts to get quite large. Maybe the new Addressables support code can be in a helper class that has its own source file. I can imagine similar pattern would be followed in the future if we add some Player, AssetBundle .manifest, or ContentFile specific information

Maybe AI can help do the leg work for that refactoring :)

timt-unity3d added 4 commits May 29, 2025 16:32

add in explict assets from build layout files

976501f

added addressables build reports

2db2e6f

initial import of several additional commands

f11d2b6

add all addressable tables

1bfdd3e

timt-unity3d requested a review from Copilot July 8, 2025 18:13

Copilot AI reviewed Jul 8, 2025

View reviewed changes

SkowronskiAndrew reviewed Jul 9, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add Addressables Report support #29

Add Addressables Report support #29

Uh oh!

timt-unity3d commented Jul 8, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jul 8, 2025

Uh oh!

Copilot AI Jul 8, 2025

Uh oh!

Copilot AI Jul 8, 2025

Uh oh!

Copilot AI Jul 8, 2025

Uh oh!

SkowronskiAndrew Jul 9, 2025

Uh oh!

SkowronskiAndrew Jul 9, 2025

Uh oh!

SkowronskiAndrew left a comment

Uh oh!

SkowronskiAndrew Jul 9, 2025

Uh oh!

SkowronskiAndrew Jul 9, 2025

Uh oh!

Uh oh!

	{ "start_time", SqliteType.Integer },
	{ "start_time", SqliteType.Text },

	create table addr_build_bundles
	create table addressables_bundles

	protected override string TableName { get => "addr_builds"; }
	protected override string TableName { get => "addressables_builds"; }

Add Addressables Report support #29

Are you sure you want to change the base?

Add Addressables Report support #29

Uh oh!

Conversation

timt-unity3d commented Jul 8, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Jul 8, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 8, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 8, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 8, 2025

Choose a reason for hiding this comment

Uh oh!

SkowronskiAndrew Jul 9, 2025

Choose a reason for hiding this comment

Uh oh!

SkowronskiAndrew Jul 9, 2025

Choose a reason for hiding this comment

Uh oh!

SkowronskiAndrew left a comment

Choose a reason for hiding this comment

Uh oh!

SkowronskiAndrew Jul 9, 2025

Choose a reason for hiding this comment

Uh oh!

SkowronskiAndrew Jul 9, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!