TS type streams #274
TS type streams #274
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
detekt found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
CaelmBleidd
force-pushed
the
caelmbleidd/type-stream
branch
from
989c4d8 to
5b944ce
Compare
| @@ -130,22 +135,34 @@ | |||
| return scope.stepResult() | |||
| } | |||
|
|
|||
| private fun visitVirtualMethodCall(scope: TsStepScope, stmt: TsVirtualMethodCallStmt) { | |||
| private fun visitVirtualMethodCall(scope: TsStepScope, stmt: TsVirtualMethodCallStmt) = with(ctx) { | |||
Check warning
Code scanning / detekt
Excessive nesting leads to hidden complexity. Prefer extracting code to make it easier to understand. Warning
| val concreteRef = scope.calcOnState { models.first().eval(instance) } | ||
|
|
||
| val uncoveredInstance = if (concreteRef.isFakeObject()) { | ||
| // We ignore the possibility of method call on primitives. |
There was a problem hiding this comment.
We should not ignore method calls on primitives. toString and toFixed are quite common for numbers.
| @@ -0,0 +1,23 @@ | |||
| package org.usvm.samples.types | |||
There was a problem hiding this comment.
Why use sub-folder for these samples? All samples are different, and "types-related" samples are not any more special than others. They all should be organize in a flat structure. The alternative is to introduce a complex hierarchy of samples, but this is a dead end --- flat a better.
| @@ -323,36 +323,52 @@ open class TsTestStateResolver( | |||
| } | |||
|
|
|||
| private fun resolveClass( | |||
| classType: EtsClassType, | |||
| refType: EtsRefType, | |||
There was a problem hiding this comment.
Keep in mind that EtsRefType might be not what you have expected.
| } | ||
| val interfaces = currentClass.implementedInterfaces | ||
| require(interfaces.isEmpty()) { TODO() } | ||
| val resolvedInterfaces = interfaces.map { interfaceSignature -> |
There was a problem hiding this comment.
In the line above you require interfaces to be empty, but here you still handle non-empty implemented interfaces.
No description provided.