Add SAST scanner failure and SARIF integrity gates#2283
Open
Errordog2 wants to merge 1 commit into
Open
Conversation
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skill Improvement ($50-150 Bounty)
Skill Modified
Skill name:
sast-configSkill path:
skills/devsecops/sast-config/What Was Wrong
Issue #2278 notes that the current SAST skill covers rule quality, coverage, suppression hygiene, and CI integration, but it can over-trust a green CI result or SARIF upload.
A workflow can satisfy surface checks while the scanner failure is hidden by
continue-on-error, shell wrappers, or upload/reporting steps. SARIF upload can still succeed with stale, empty, partial, or fallback output, making branch protection look green even when analysis did not complete for the current commit.What This PR Fixes
sast-configto1.0.1.Scanner Failure and SARIF Integrity Gatessection under CI integration review.Scanner Failure and SARIF Integritytable.Evidence
Before: Reviewers could treat SAST as passing when a wrapper/upload job succeeded, even if the scanner failed or produced stale/empty SARIF.
After: Reviewers must document scanner exit handling, required-check binding, current commit/run binding, SARIF freshness, empty-result semantics, and partial/skipped analysis handling before trusting a clean SAST result.
Test Cases Added/Updated
tests/vulnerable/)tests/benign/)This existing skill stores examples in Markdown guidance files; the change keeps scope to
SKILL.md.Validation
git diff --check.github/workflows/lint-skills.ymlindex.yamlfile-existence check matching.github/workflows/validate-index.ymlskills/androles/1.0.1,Scanner Failure and SARIF Integrity Gates,continue-on-error: true,upload-sarif, current commit binding, SARIF freshness, empty result semantics, SAST-CI-FAIL triggers, required-check binding, and stale/partial SARIF handlingBounty Tier
Bounty Info
Fixes #2278