Add scanner asset identity freshness gates#2275
Open
Errordog2 wants to merge 1 commit into
Open
Conversation
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skill Improvement ($50-150 Bounty)
Skill Modified
Skill name:
scanner-tuningSkill path:
skills/vuln-management/scanner-tuning/What Was Wrong
The scanner tuning skill had good false-positive taxonomy, authenticated scan guidance, severity override rules, and cross-scanner correlation, but it assumed that an affected asset remains stable once named by IP, hostname, or image tag.
In elastic cloud, container, and Kubernetes environments, that can misclassify stale findings:
Related review issue: #2007
What This PR Fixes
scanner-tuningto1.0.1.Asset Identity Freshness Gatebefore true-positive, false-positive, suppression, or severity override decisions.Asset Identity Freshnessoutput table.Evidence
Before: Scanner findings could be suppressed, escalated, or downgraded using IP/hostname/tag evidence even if the underlying workload had been replaced.
After: Reviewers must prove the scanner finding maps to the current stable asset identity, or mark the result stale / Not Evaluable / requiring revalidation.
Test Cases Added/Updated
tests/vulnerable/)tests/benign/)This existing skill stores examples in Markdown guidance files; the change keeps scope to
SKILL.md.Validation
git diff --check.github/workflows/lint-skills.ymlindex.yamlfile-existence check matching.github/workflows/validate-index.ymlskills/androles/1.0.1,Asset Identity Freshness, stable asset IDs, inventory timestamp, scanner asset UUID, image digest, Kubernetes UID, stale scan handling, and Not Evaluable handlingBounty Tier
Bounty Info
Fixes #2007