Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some posm tests #164

Closed
wants to merge 103 commits into from
Closed

Some posm tests #164

wants to merge 103 commits into from

Conversation

saucepoint
Copy link
Collaborator

  • restored commented-out tests
  • added ERC721 transfer tests for "mint, transfer, and __" flows
  • added "rebalance" (burn & mint) test

Note: left out 6909 tests as we're still deciding how to support it..

snreynolds and others added 30 commits December 5, 2023 12:53
@snreynolds
initial thoughts lock and batch
6c63e1f
@snreynolds
update safecallback with constructor
ad39d19
@snreynolds
simple batch under lock
64fc40a
@snreynolds
oops
a707c20
@saucepoint
misc version bump; will conflict but can resolve later
1d0e566
@saucepoint
defining types and different levels of abstractions
4f8bbd2
@saucepoint
merge in main; resolve conflicts
c4c9dcd
@saucepoint
merge in main?
187fc3d
@saucepoint
wip
ee27f4f
@saucepoint
merge in main
30ac060
@saucepoint
misc fixes with main:latest
d1c5897
@saucepoint
basic mint
7a134a5
@saucepoint
begin moving tests to fuzz
7bd2996
@saucepoint
test for slippage
307f4bb
@saucepoint
burning
109caf4
@saucepoint
decrease liquidity
1bf080f
@saucepoint
mint transfer burn, liquidityOf accounting
40f042c
@saucepoint
wip
6b1c7cb
@saucepoint
refactor to use CurrencySettleTake
fa511d0
@saucepoint
basic fee collection
a0e0a44
@saucepoint
wip
0d936d4
@saucepoint
misc fix
4be3c2a
@saucepoint
fee collection for independent same-range parties
7fa4c54
@saucepoint
LiquidityPosition -> LiquidityRange
aae9697
@saucepoint
erc20 fee collection
5dec534
@saucepoint
decrease liquidity with fee collection
1196c6a
@saucepoint
wip test decrease liquidity on same range
3d317e8
@saucepoint
reworked fuzzers; more testing on fee claims for liquidity decreasing
31a70cb
@saucepoint
merge in main; update flipped deltas; update lockAcquired signature
f844687
@saucepoint
forge fmt
666faf8
saucepoint and others added 7 commits July 18, 2024 17:55
@saucepoint
additional tests around using donate for fee revenue
df313d8
@saucepoint
restore test: decreasing liquidity also claims fees
3d682c6
@saucepoint
add NFT transfer-and-operation tests
792d605
@saucepoint
test for complex operation: rebalance
8a9a357
@saucepoint @snreynolds
ERC721Permit cleanup (#161)
85bab02 
* wip Solmate ERC721

* the queens dead, you may put down your arms. with this commit, i hereby lay BaseLiquidityManagement and the ideals of fee accounting finally to rest

* refactor tokenId => LiquidityRange; begin separating PoolKey

* move comment

---------

Co-authored-by: Sara Reynolds <[email protected]>
@snreynolds
remove old files, imports
7c87344
@saucepoint
merge in dev-posm; fix conflicts; regenerate gas
93d5d0d
@saucepoint saucepoint added the posm position manager label Jul 19, 2024
@snreynolds
Copy link
Member

Could you pull in dev-posm? On Friday I fixed some of the commented out tests so there might be merge conflicts

@saucepoint saucepoint mentioned this pull request Jul 22, 2024
Merged
29 tasks
Base automatically changed from dev-posm to main July 23, 2024 12:29
@saucepoint saucepoint mentioned this pull request Jul 24, 2024
Merged
3 tasks
@saucepoint
Copy link
Collaborator Author

replaced with cherry-picked PR

@saucepoint saucepoint closed this Jul 24, 2024
@saucepoint saucepoint deleted the posm-tests branch July 29, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
posm position manager
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saucepoint @snreynolds