Define and Implement Dynamic Fee Update Event #926
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In response to issue Uniswap#920. This event should then be emitted in every call to `updateDynamicLPFee` in contracts which inherit from `IPoolManager`
…r.sol In response to Issue Uniswap#920. The event is declared in `IPoolManager.sol` which `PoolManager.sol` inherits from.
|
Hi! We appreciate your contribution, however the PoolManager bytecode is frozen. We will not be able to make any more changes 🙏 |
|
@hensha256 Ok makes sense. Is it safe to say that all the smart contracts in v4-core are in the same boat or just specifically that directory? |
|
This event is essential to get a proper view of the pool state externally. Are you saying you'd rather release it in this very difficult to work with state instead of making this trivial change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
#920
Description of changes
This PR declares a new event
DynamicLPFeeUpdatedwithin theIPoolManagercontract (found inIPoolManager.sol) which is essentially an interface contract to be inherited by thePoolManagercontract (found inPoolManager.sol). The new event is emitted whenever the functionupdateDynamicLPFeein is called, and is called on the last line of the function definition to ensure it is only called in the case that the function has executed properly.In using
grep -rl "is IPoolManager" --include="*.sol" .We can see that the only two contracts in the
v4-corerepo which inherit fromIPoolManagerare in./src/test/ProxyPoolManager.soland./src/test/ProxyPoolManager.sol. I’ve implemented the event emissions appropriately in both cases.