-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add unit tests for handlePoolCreated #227
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
a18518d
to
3ca291f
Compare
4fe3a56
to
2b520a9
Compare
2b520a9
to
4cfbce3
Compare
5e4c922
to
87cfa3d
Compare
ca097d3
to
dbe0058
Compare
ccd3103
to
4b42578
Compare
This was referenced May 22, 2024
Merged
mz-
approved these changes
May 28, 2024
andysmith415
approved these changes
May 29, 2024
4b42578
to
1dfb743
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds unit test for the
![image](https://private-user-images.githubusercontent.com/44713145/332826837-1f9ce14a-b19f-461f-bdbb-1bf34497f04a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzNzc2NTksIm5iZiI6MTczOTM3NzM1OSwicGF0aCI6Ii80NDcxMzE0NS8zMzI4MjY4MzctMWY5Y2UxNGEtYjE5Zi00NjFmLWJkYmItMWJmMzQ0OTdmMDRhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEyVDE2MjIzOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTFkZTU4YTBkOGI4ZDgwMjhjYTdjZTJiYTE4ZWEyNmVhN2NmNWU4YWZmMjk5NjkyZWUzMGYwODIxNDI5M2FhMTAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.HKLGP1X4fYZFDPJEfToeP3uMjHdMgE68KRNMF6pjrto)
poolCreated
handler and updates the github action for running the unit tests (see image for example of failing test)Note that some changes were made to the subgraph code to support testing
StaticTokenDefinition
structure to be a static constant rather than a class method.