fix: fix incorrect path substitution in sed command #73
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was a missing
/
after$input_dir
in thesed
command, which could result in incorrect path substitution. If the path started with$input_dir
but contained subdirectories, the replacement might not work as expected.Now, the command explicitly matches the beginning of the string using
^
and ensures$input_dir/
is properly removed.How Has This Been Tested?
Tested by running the modified command with various input paths, including cases with and without subdirectories. The results now correctly remove
$input_dir/
only when it appears at the beginning of the path.Checklist:
Before deployment
After deployment
Considerations
forge fmt
and prettier to ensure the code style is validAdditional context
Verification
For example, given:
The original
sed
command would produce:However, without
/
afterinput_dir
, it could produce incorrect results if the path structure is more complex.