Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audit(11): Optimize gas in gas adjustment calculations #303

Merged
merged 3 commits into from
Oct 9, 2024
Merged

Conversation

alanhwu
Copy link
Collaborator

@alanhwu alanhwu commented Oct 1, 2024

Don't perform gas adjustments if the adjustmentPerGweiBaseFee field is 0.

@alanhwu alanhwu linked an issue Oct 1, 2024 that may be closed by this pull request
zhongeric
zhongeric previously approved these changes Oct 2, 2024
Copy link
Collaborator

@zhongeric zhongeric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but I would expect the gas snapshots to update?

zhongeric
zhongeric previously approved these changes Oct 3, 2024
codyborn
codyborn previously approved these changes Oct 8, 2024
@alanhwu alanhwu dismissed stale reviews from codyborn and zhongeric via ee6d8c1 October 9, 2024 22:17
@alanhwu alanhwu merged commit 8f91f49 into main Oct 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

audit: 11
3 participants