audit(9): Round gas adjustments in favor of swapper #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
zhongeric
reviewed
Oct 2, 2024
src/reactors/V3DutchOrderReactor.sol
Outdated
| @@ -112,15 +112,19 @@ contract V3DutchOrderReactor is BaseReactor { | |||
| // positive means an increase in gas | |||
| int256 gasDeltaGwei = block.basefee.sub(order.startingBaseFee); | |||
|
|
|||
| // Gas increase should increase input | |||
| int256 inputDelta = int256(order.baseInput.adjustmentPerGweiBaseFee) * gasDeltaGwei / 1 gwei; | |||
| // Gas increase should increase input (round up when positive, down when negative) | |||
There was a problem hiding this comment.
nit: add comment here about how less input = favoring swapper
Comment on lines
1448
to
1449
| assertEq(resolvedOrder.input.amount, 100 ether - 0.08 gwei, "Input should handle small negative gas changes"); | ||
| assertEq(resolvedOrder.outputs[0].amount, 100 ether + 0.08 gwei, "Output should handle small negative gas changes"); |
There was a problem hiding this comment.
is there a test that specifically tests the rounding down / up?
There was a problem hiding this comment.
accidentally tested using gwei instead of wei. fixed
zhongeric
reviewed
Oct 3, 2024
zhongeric
previously approved these changes
Oct 4, 2024
codyborn
previously approved these changes
Oct 8, 2024
codyborn
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Round gas adjustments in favor of swappers based on input/output and gas price increasing/decreasing