feat: early return dutch decay if none #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhongeric
previously approved these changes
Apr 9, 2024
| @@ -28,7 +28,9 @@ library DutchDecayLib { | |||
| view | |||
| returns (uint256 decayedAmount) | |||
| { | |||
| if (decayEndTime <= decayStartTime) { | |||
| if (startAmount == endAmount) { | |||
There was a problem hiding this comment.
a little strange that the decay times are not validated if startAmount==endAmount
There was a problem hiding this comment.
wdyt about putting this check after the time based ones?
There was a problem hiding this comment.
part of the point of this issue is that the time-based ones are irrelevant if startamount == endamount, which is always true for one of inputs or outputs. timings will be validated for whichever one is decaying
marktoda
force-pushed
the
early-return-decay
branch
from
7cdd074 to
863f3c7
Compare
zhongeric
previously approved these changes
Apr 15, 2024
If startAmount == endAmount, early return. This is always true for either the inputs or outputs of an order, so saves the decay calculation half the time
marktoda
force-pushed
the
early-return-decay
branch
from
863f3c7 to
45008f8
Compare
zhongeric
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If startAmount == endAmount, early return. This is always true for
either the inputs or outputs of an order, so saves the decay calculation
half the time