feat: add v2 deployment #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hensha256
reviewed
Mar 19, 2024
marktoda
force-pushed
the
add-v2-deployer
branch
from
0400ba4 to
28fcfa5
Compare
hensha256
reviewed
Mar 19, 2024
| function setUp() public {} | ||
|
|
||
| function run() public returns (V2DutchOrderDeployment memory deployment) { | ||
| address owner = vm.envAddress("FOUNDRY_REACTOR_OWNER"); |
There was a problem hiding this comment.
1 more nit - console log the owner just in case this parsing breaks in some way
marktoda
force-pushed
the
add-v2-deployer
branch
from
28fcfa5 to
4640763
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.