More reactor tests, address PR feedback

.forge-snapshots/Base-V3DutchOrder-BaseExecuteSingleWithFee.snap

@@ -1 +1 @@
-192981
+192980

.forge-snapshots/Base-V3DutchOrder-ExecuteBatch.snap

@@ -1 +1 @@
-219434
+219432

.forge-snapshots/Base-V3DutchOrder-ExecuteBatchMultipleOutputs.snap

@@ -1 +1 @@
-231444
+231439

.forge-snapshots/Base-V3DutchOrder-ExecuteBatchMultipleOutputsDifferentTokens.snap

@@ -1 +1 @@
-287371
+287363

.forge-snapshots/Base-V3DutchOrder-ExecuteBatchNativeOutput.snap

@@ -1 +1 @@
-212953
+212951

.forge-snapshots/Base-V3DutchOrder-ExecuteSingle.snap

@@ -1 +1 @@
-159369
+159368

.forge-snapshots/Base-V3DutchOrder-ExecuteSingleNativeOutput.snap

@@ -1 +1 @@
-144927
+144926

.forge-snapshots/Base-V3DutchOrder-ExecuteSingleValidation.snap

@@ -1 +1 @@
-168675
+168674

.forge-snapshots/Base-V3DutchOrder-RevertInvalidNonce.snap

@@ -1 +1 @@
-37963
+37962

.forge-snapshots/V3-DutchDecayBounded.snap

@@ -1 +1 @@
-5778
+1070

.forge-snapshots/V3-DutchDecayFullyDecayed.snap

@@ -1 +1 @@
-14782
+14810

.forge-snapshots/V3-DutchDecayFullyDecayedNegative.snap

@@ -1 +1 @@
-14634
+14662

.forge-snapshots/V3-ExtendedMultiPointDutchDecay.snap

@@ -1 +1 @@
-219186
+208112

.forge-snapshots/V3-LocateCurvePositionMulti.snap

@@ -1 +1 @@
-24798
+24086

.forge-snapshots/V3-LocateCurvePositionSingle.snap

@@ -1 +1 @@
-8820
+8758

.forge-snapshots/V3-MultiPointDutchDecay.snap

@@ -1 +1 @@
-51976
+51174

src/lib/NonlinearDutchDecayLib.sol

@@ -5,7 +5,7 @@ import {OutputToken, InputToken} from "../base/ReactorStructs.sol";
 import {V3DutchOutput, V3DutchInput, NonlinearDutchDecay} from "../lib/V3DutchOrderLib.sol";
 import {FixedPointMathLib} from "solmate/src/utils/FixedPointMathLib.sol";
 import {sub} from "./MathExt.sol";
-import {Uint16Array, fromUnderlying} from "../types/Uint16Array.sol";
+import {Uint16ArrayLibrary, Uint16Array, fromUnderlying} from "../types/Uint16Array.sol";
 
 /// @notice thrown when the decay curve is invalid
 error InvalidDecayCurve();
@@ -14,6 +14,7 @@ error InvalidDecayCurve();
 library NonlinearDutchDecayLib {
     using FixedPointMathLib for uint256;
     using {sub} for uint256;
+    using Uint16ArrayLibrary for Uint16Array;
 
     /// @notice locates the current position on the curve and calculates the decay
     /// @param curve The curve to search
@@ -61,12 +62,12 @@ library NonlinearDutchDecayLib {
         returns (uint16 prev, uint16 next)
     {
         Uint16Array relativeBlocks = fromUnderlying(curve.relativeBlocks);
-        while (next < curve.relativeAmounts.length) {
+        uint16 curveLength = uint16(curve.relativeAmounts.length);
+        for (; next < curveLength; next++) {
             if (relativeBlocks.getElement(next) >= currentRelativeBlock) {
                 return (prev, next);
             }
             prev = next;
-            next++;
         }
         return (next - 1, next - 1);
     }

src/lib/V3DutchOrderLib.sol

@@ -143,8 +143,8 @@ library V3DutchOrderLib {
     function hash(V3DutchOutput[] memory outputs) internal pure returns (bytes32) {
         unchecked {
             bytes memory packedHashes = new bytes(32 * outputs.length);
-
-            for (uint256 i = 0; i < outputs.length; i++) {
+            uint256 outputsLength = outputs.length;
+            for (uint256 i = 0; i < outputsLength; i++) {
                 bytes32 outputHash = hash(outputs[i]);
                 assembly {
                     mstore(add(add(packedHashes, 0x20), mul(i, 0x20)), outputHash)

src/reactors/V3DutchOrderReactor.sol

@@ -51,9 +51,6 @@ contract V3DutchOrderReactor is BaseReactor {
         // hash the order _before_ overriding amounts, as this is the hash the user would have signed
         bytes32 orderHash = order.hash();
 
-        if (order.info.deadline < block.timestamp) {
-            revert DeadlineReached();
-        }
         _validateOrder(orderHash, order);
         _updateWithCosignerAmounts(order);
 
@@ -108,8 +105,12 @@ contract V3DutchOrderReactor is BaseReactor {
 
     /// @notice validate the dutch order fields
     /// - deadline must have not passed
+    /// - cosigner is valid if specified
     /// @dev Throws if the order is invalid
-    function _validateOrder(bytes32 orderHash, V3DutchOrder memory order) internal pure {
+    function _validateOrder(bytes32 orderHash, V3DutchOrder memory order) internal view {
+        if (order.info.deadline < block.timestamp) {
+            revert DeadlineReached();
+        }
         (bytes32 r, bytes32 s) = abi.decode(order.cosignature, (bytes32, bytes32));
         uint8 v = uint8(order.cosignature[64]);
         // cosigner signs over (orderHash || cosignerData)

src/types/Uint16Array.sol

@@ -4,8 +4,6 @@ pragma solidity ^0.8.0;
 /// @dev An uint16 array of max 16 values packed into a single uint256
 type Uint16Array is uint256;
 
-using Uint16ArrayLibrary for Uint16Array global;
-
 error IndexOutOfBounds();
 error InvalidArrLength();
 

test/lib/NonLinearDutchDecayLib.t.sol

@@ -200,7 +200,6 @@ contract NonlinearDutchDecayLibTest is Test, GasSnapshot {
         vm.assume(decayAmount > 0);
         vm.assume(decayAmount < 2 ** 255 - 1);
         vm.assume(startAmount <= UINT256_MAX - decayAmount);
-        vm.assume(decayDuration > 0);
 
         NonlinearDutchDecay memory curve = CurveBuilder.singlePointCurve(decayDuration, 0 - int256(decayAmount));
         snapStart("V3-DutchDecayBounded");

test/lib/Uint16Array.t.sol

@@ -5,9 +5,11 @@ import {Test} from "forge-std/Test.sol";
 import {NonlinearDutchDecayLib} from "../../src/lib/NonlinearDutchDecayLib.sol";
 import {V3DutchOutput, V3DutchInput, NonlinearDutchDecay} from "../../src/lib/V3DutchOrderLib.sol";
 import {ArrayBuilder} from "../util/ArrayBuilder.sol";
-import {Uint16Array, toUint16Array, InvalidArrLength, IndexOutOfBounds} from "../../src/types/Uint16Array.sol";
+import {Uint16ArrayLibrary, Uint16Array, toUint16Array, InvalidArrLength, IndexOutOfBounds} from "../../src/types/Uint16Array.sol";
 
 contract Uint16ArrayTest is Test {
+    using Uint16ArrayLibrary for Uint16Array;
+
     function testGetElement(uint16 value, uint16 length) public {
         vm.assume(length <= 16);
         Uint16Array packedArr = toUint16Array(ArrayBuilder.fillUint16(length, value));