Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pylint noqa comments #3322

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

johannaengland
Copy link
Contributor

Should be merged after #3299. Closes #3321.

Copy link

github-actions bot commented Mar 6, 2025

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 103 0 3.34s
✅ PYTHON ruff 103 0 0.03s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@johannaengland johannaengland added the nonews No news fragment is necessary for this PR (e.g. refactoring, cleanups, workflow/development changes) label Mar 6, 2025
Copy link

github-actions bot commented Mar 6, 2025

Test results

   12 files     12 suites   11m 37s ⏱️
2 176 tests 2 176 ✅ 0 💤 0 ❌
6 003 runs  6 003 ✅ 0 💤 0 ❌

Results for commit d508710.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.76%. Comparing base (237e1b6) to head (d508710).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3322   +/-   ##
=======================================
  Coverage   60.76%   60.76%           
=======================================
  Files         606      606           
  Lines       43794    43793    -1     
  Branches       48       48           
=======================================
+ Hits        26610    26612    +2     
+ Misses      17172    17169    -3     
  Partials       12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

After removing pylint these are not necessary any longer
@johannaengland johannaengland force-pushed the cleanup/remove-pylint-noqa-comments branch from e98746f to d508710 Compare March 7, 2025 09:25
Copy link

sonarqubecloud bot commented Mar 7, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup nonews No news fragment is necessary for this PR (e.g. refactoring, cleanups, workflow/development changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove/adapt noqa pylint comments
1 participant