Check destinations before forking #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #616 +/- ##
==========================================
+ Coverage 82.04% 82.08% +0.04%
==========================================
Files 73 73
Lines 3531 3539 +8
==========================================
+ Hits 2897 2905 +8
Misses 634 634
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
lunkwill42
requested changes
Apr 17, 2023
lunkwill42
approved these changes
Apr 18, 2023
There was a problem hiding this comment.
With #618 applied, this works. It's still not superfast, but that's mostly the fault of the bulk endpoint itself...
johannaengland
requested changes
Apr 18, 2023
hmpf
force-pushed
the
check-dests-before-fork
branch
from
dc4e344 to
71b5f0d
Compare
hmpf
force-pushed
the
check-dests-before-fork
branch
from
71b5f0d to
aca690f
Compare
johannaengland
requested changes
Apr 19, 2023
It seems my commit via github didn't take, seems to have worked when I tried just now. You might not be allowed to review anymore... |
Co-authored-by: Johanna England <[email protected]>
hmpf
force-pushed
the
check-dests-before-fork
branch
from
49c2f13 to
6c1b8cd
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
johannaengland
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code now only forks a new process if there is anything to send.
Note: The functions in
argus/notificationprofile/media/__init__.pyhas been sorted differently since the actual sending functions are parameters to the filter-function and therefore must come before it.Other problems I found:
plugin.sendshould be on the base-class and not overriden. Then the base class controls whether it wants a queryset or a list of destinations.