Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate project to Flutter best practice #155

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TheOneWithTheBraid
Copy link
Contributor

  • BREAKING: remove async gaps from BuildContext
    • See README for migration
  • BREAKING: remove built-in provider storage
    • See README for migration
  • Fix missing await statement for asynchronous tasks

@p1gp1g
Copy link
Member

p1gp1g commented Aug 14, 2024

That's OK to remove the dialog from the unifiedpush package, if we provide a unifiedpush_ui package that does it. I think this package should not depend on unifiedpush to reduce maintenance load.

If we go that way, then:

  1. We should publish unifiedpush_ui
  2. We should deprecate registerAppWithDialog
  3. Publish a new version
  4. Remove registerAppWithDialog in the next major version, which should happen in a few months

What do you think about this ? If you like the idea, do you want to help for the new lib ?

* BREAKING: remove async gaps from `BuildContext`
  * See README for migration
* BREAKING: remove built-in provider storage
  * See README for migration
* Fix missing await statement for asynchronous tasks

Signed-off-by: The one with the braid <[email protected]>
@p1gp1g
Copy link
Member

p1gp1g commented Aug 25, 2024

Gentle ping for the question @TheOneWithTheBraid

@TheOneWithTheBraid
Copy link
Contributor Author

TheOneWithTheBraid commented Aug 25, 2024 via email

@p1gp1g
Copy link
Member

p1gp1g commented Aug 25, 2024

Thanks for the answer, I'll also see if I've time to do it

@p1gp1g
Copy link
Member

p1gp1g commented Aug 28, 2024

What do you think about this solution ? https://codeberg.org/UnifiedPush/flutter-connector/pulls/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants