Skip to content

Allow to fast scroll by album artists on the albums tab#1401

Merged
Chaphasilor merged 2 commits intoredesignfrom
fast-scroll-albums-by-album-artist
Oct 8, 2025
Merged

Allow to fast scroll by album artists on the albums tab#1401
Chaphasilor merged 2 commits intoredesignfrom
fast-scroll-albums-by-album-artist

Conversation

@Maxr1998
Copy link
Collaborator

@Maxr1998 Maxr1998 commented Oct 4, 2025

Changes

Updates the scrollToLetter function to allow fast scrolling to a specific album artist if the sort by is set to that option.
Also makes the fast scroller visible for the album artist sort type.

Related Issues

Fixes #1395

@Maxr1998 Maxr1998 requested a review from Chaphasilor October 4, 2025 00:59
@Maxr1998 Maxr1998 added enhancement Improves an existing feature redesign-beta Issues related to the beta/redsigned version of Finamp labels Oct 4, 2025
@Maxr1998 Maxr1998 force-pushed the fast-scroll-albums-by-album-artist branch from 2608f7c to 149ff24 Compare October 4, 2025 01:03
@Maxr1998 Maxr1998 force-pushed the fast-scroll-albums-by-album-artist branch from 149ff24 to 9e2d8bc Compare October 4, 2025 23:45
@Maxr1998 Maxr1998 added the hacktoberfest-accepted Issues accepted to count as a Hacktoberfest contribution label Oct 4, 2025
@Maxr1998 Maxr1998 requested a review from Komodo5197 October 4, 2025 23:46
@Chaphasilor
Copy link
Collaborator

I guess this is ready to merge then?

@Maxr1998
Copy link
Collaborator Author

Maxr1998 commented Oct 7, 2025

I was waiting for @Komodo5197 to review my adjustments and merge it, but from my side it's ready.

@Komodo5197
Copy link
Collaborator

It looks good to me.

@Chaphasilor Chaphasilor merged commit 4a67a6b into redesign Oct 8, 2025
5 checks passed
@Chaphasilor Chaphasilor deleted the fast-scroll-albums-by-album-artist branch October 8, 2025 08:21
@Chaphasilor
Copy link
Collaborator

Perfect, thanks!

@Maxr1998
Copy link
Collaborator Author

Maxr1998 commented Oct 8, 2025

Thanks for the reviews and merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Improves an existing feature hacktoberfest-accepted Issues accepted to count as a Hacktoberfest contribution redesign-beta Issues related to the beta/redsigned version of Finamp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants