Merged
Conversation
Maxr1998
added
refactoring
Maxr1998
force-pushed
the
link-handler-tweaks
branch
from
a16e24a to
384b7f0
Compare
Collaborator
|
Neat. Does clicking a |
Chaphasilor
added
hacktoberfest-accepted
Collaborator
Author
I'll have to check again, but I thought it should work already. |
Maxr1998
force-pushed
the
link-handler-tweaks
branch
from
384b7f0 to
04b660d
Compare
Collaborator
Author
|
@Chaphasilor yes, still works great! |
Collaborator
|
awesome, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
As suggested by @Komodo5197, I replaced the retry loop with a SchedulerBinding frame callback to ensure the app is ready before handling links. Tested locally with the Linux build.
Related Issues
Originally discussed in 254dc41.