Enable origin utilization in transform calculations#107
Closed
opencma wants to merge 1 commit intoUnderwaterApps:masterfrom
Closed
Enable origin utilization in transform calculations#107opencma wants to merge 1 commit intoUnderwaterApps:masterfrom
opencma wants to merge 1 commit intoUnderwaterApps:masterfrom
Conversation
Contributor
|
Could you elaborate a bit more on what issue this fixes? Or what does this add? |
Author
|
Currently, when transforming a composite the origin is hard coded to (0,0). The boolean variable added to TransformComponent will now allow the settable origin to be used. |
Contributor
|
But if you have to set that default anyway for each component, why not set directly originX originY values instead? |
Author
|
For backwards compatibility. It's marked as a TODO. Really any implementation that would allow for values other than the hardcoded 0 would be nice. |
|
So guys, why isn't this or #108 accepted and merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backwards compatible. Defaults to false and uses (0,0) as origin.