Holo.Light --> DeviceDefault - #21
Open
MBQ- wants to merge 1 commit into
Open
Conversation
I remember running the ROM a while ago, and there was one case where the text was white-on-white, making it difficult to read. I know you can't change a ListViews textColor unless you switch the whole theme of the app, so I'm thinking this may be a good fix. Holo Light looks elegant, dont get me wrong, but it almost seems 'out of place' in the Settings app because the background of this ROMs settings is the stock color. So, using DeviceDefault might work better.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I remember running the ROM a while ago, and there was one case where the text was white-on-white, making it difficult to read.
I know you can't change a ListViews textColor unless you switch the whole theme of the app, so I'm thinking this may be a good fix. Holo Light looks elegant, dont get me wrong, but it almost seems 'out of place' in the Settings app because the background of this ROMs settings is the stock color. So, using DeviceDefault might work better.