Skip to content
This repository has been archived by the owner on Dec 18, 2024. It is now read-only.

Implement led test mode. #234

Merged
merged 5 commits into from
Sep 8, 2024
Merged

Implement led test mode. #234

merged 5 commits into from
Sep 8, 2024

Conversation

kareltucek
Copy link
Contributor

Closes UltimateHackingKeyboard/firmware#925.

Not tested on uhk60. For some reason agent can't find it.

@mondalaci
Copy link
Member

Please extend the implementation with the following behavior:

  • Don't emit any scancodes when in test mode
  • After switching to the text mode and all LEDs are enabled, when pressing the first key, disable all LEDs on both sides except the LED of the pressed key

@kareltucek
Copy link
Contributor Author

After switching to the text mode and all LEDs are enabled, when pressing the first key, disable all LEDs on both sides except the LED of the pressed key

Please no, unless there is a good reason to justify that requirement.

It would greatly increase the complexity of the entire solution.

@mondalaci
Copy link
Member

Ok, it's not a hard requirement.

Can you suppress the scancodes, though?

@kareltucek
Copy link
Contributor Author

Yes, working on it!

@kareltucek
Copy link
Contributor Author

kareltucek commented Sep 7, 2024

I am implementing the suppression for uhk80 only at the moment.

If we want it to work on uhk60, I can do that, but it needs a separate solution and so I would prefer not to do it now given the mentioned testing issues.

Is that ok?

@kareltucek
Copy link
Contributor Author

(Done.)

@mondalaci
Copy link
Member

It'd be favorable if the keys could be lit up on keypress, not on key release. (Only if this can be implemented quickly.)

Some keys don't light up the relevant LEDs, including ScrLk, Pause, Ins, Del, ,, ., /.

@kareltucek
Copy link
Contributor Author

(Remains to test / finish UHK60 -> telegram.)

@mondalaci mondalaci merged commit 3287dbf into master Sep 8, 2024
1 check passed
@mondalaci mondalaci deleted the testled_mode branch September 8, 2024 06:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Key switch LED test mode
2 participants